Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve Makefile install #155

Merged
merged 1 commit into from
Aug 2, 2022
Merged

improve Makefile install #155

merged 1 commit into from
Aug 2, 2022

Conversation

hugy718
Copy link
Contributor

@hugy718 hugy718 commented May 10, 2022

quick fix of #154

@indutny indutny changed the title imporve Makefile install improve Makefile install May 14, 2022
@indutny
Copy link
Member

indutny commented May 14, 2022

Hello! Thank you for this PR. I just tried to run install with -D on macOS, and I don't think it works:

% install -D
install: illegal option -- D
usage: install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 file2
       install [-bCcpSsv] [-B suffix] [-f flags] [-g group] [-m mode]
               [-o owner] file1 ... fileN directory
       install -d [-v] [-g group] [-m mode] [-o owner] directory ...

It is not on the man page either...

@hugy718 hugy718 closed this May 15, 2022
@hugy718 hugy718 reopened this May 15, 2022
@hugy718
Copy link
Contributor Author

hugy718 commented May 15, 2022

Thanks for pointing out that. I changed to use -d to create directories before copy instead of -D.

ShogunPanda
ShogunPanda approved these changes Aug 2, 2022
View reviewed changes
Copy link
Contributor

@ShogunPanda ShogunPanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ShogunPanda ShogunPanda merged commit da60b0b into nodejs:main Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ShogunPanda ShogunPanda ShogunPanda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hugy718 @indutny @ShogunPanda